Skip to content

request npm-package deprecated and tests wont run #1420

@Abhilash-Chandran

Description

@Abhilash-Chandran

As of Feb 11, 2020 the npm package request is deprecated.
Please check this npm site and github repo.

This means, the tests cannot depend on this package. Test wont run in a freshly setup dev environment for developers.

Following is the error caused in Ubuntu 18 and node 12.16.1....

root@c195251b0e84:/quicktype# npm run test

> quicktype@15.0.0 test /quicktype
> jest && script/test

FAIL src/__tests__/cli/ci.test.ts
  ● Test suite failed to run

    Cannot find module 'request'

      at node_modules/request-promise-native/lib/rp.js:8:12
      at module.exports (node_modules/stealthy-require/lib/index.js:62:23)
      at Object.<anonymous> (node_modules/request-promise-native/lib/rp.js:7:15)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        0.097s
Ran all test suites.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! quicktype@15.0.0 test: `jest && script/test`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the quicktype@15.0.0 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2020-03-09T21_51_00_393Z-debug.log

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions