app/cmd: introduces preprocessors for session #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndling logic into respective components. Signed-off-by: Jeff Lindsay <progrium@gmail.com>
Contributor
Author
|
Grumble. Not sure which I'd rather do: update the CI image to Go 1.8 or change sorting back to 1.7 style. :\ |
Signed-off-by: Jeff Lindsay <progrium@gmail.com>
Contributor
Author
|
CI passed. Quick review @MattAitchison ? |
mattatcha
approved these changes
May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components can now hook into early session handling. A number of early session handling logic has been put into their respective components. This means you can easily turn them off by disabling their component.
For example, one you might want to turn off in development is the
accesscomponent which checks GitHub if your user is in the alpha group. This is shown as an example in.env.example.Another example is disabling the notice on first-time SSH login to login via web first. This is currently tied to the
consolecomponent, which we probably don't want to disable entirely, but eventually we can split this out or make it configurable for that component. To disable this notice and the console interface you'd set your.env: