-
Notifications
You must be signed in to change notification settings - Fork 0
fix: explicitly allow null coords in BoundingBox interface #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ChasNelson1990
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also turn strictNullCheck on for ANNOTATE?
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-wave-0f4ddd903-673.westeurope.azurestaticapps.net |
Don't know. I think it was Silvia who enabled them originally, there was a specific reason but I've forgotten it. I think it's generally regarded as good practice, but will probably require us to go through the repo and put |
|
@cooper667 @SilviaZeta thoughts? |
Yea, we should have one tsconfig we extend everywhere same as eslint config |
yes, I needed the setting for schema validation. It has proven to be really useful, but as @philipjackson says, it will require adding |
|
Enabling |
Description
This was necessary for the
makeAnnotationsJsonunit test in DOMINATE, because it turns out theAnnotationinterface doesn't actually allow fornullcoordinates for bounding boxes (which is currently how "no bounding box" is represented) whenstrictNullChecksis enabled. We havestrictNullChecksset in DOMINATE but not in ANNOTATE, which is why this didn't cause a problem there.Also exported the
SplineandBoundingBoxinterfaces so I don't have to duplicate them in the unit test.Checklist:
Put an
xin the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!