Skip to content

chore: restructure @next folder#703

Merged
marthayaputra merged 1 commit intov4from
feature/next-folder-refactoring
Jan 6, 2023
Merged

chore: restructure @next folder#703
marthayaputra merged 1 commit intov4from
feature/next-folder-refactoring

Conversation

@marthayaputra
Copy link
Copy Markdown
Contributor

No description provided.

@marthayaputra marthayaputra force-pushed the feature/next-folder-refactoring branch from 323fce3 to cfd2864 Compare January 6, 2023 03:36
Copy link
Copy Markdown
Contributor

@ninariccimarie ninariccimarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you help to update the gitignore file instead of src/General/@next/Icon/components to src/@next/Icon/components?

I was thinking we should also put the non component directories (the ones that start with small letters) inside src/@next/utilities instead to have an organized separation.

@marthayaputra marthayaputra force-pushed the feature/next-folder-refactoring branch from cfd2864 to 44b833c Compare January 6, 2023 03:44
@marthayaputra marthayaputra force-pushed the feature/next-folder-refactoring branch from 44b833c to 67cebe6 Compare January 6, 2023 03:57
@marthayaputra
Copy link
Copy Markdown
Contributor Author

can you help to update the gitignore file instead of src/General/@next/Icon/components to src/@next/Icon/components?

I was thinking we should also put the non component directories (the ones that start with small letters) inside src/@next/utilities instead to have an organized separation.

Yeah, good idea updated

Copy link
Copy Markdown
Contributor

@ninariccimarie ninariccimarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! LGTM!

@marthayaputra marthayaputra merged commit c539920 into v4 Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants