Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

Add searchGalaxy icon#107

Merged
oliviacpu merged 3 commits intomasterfrom
ch9894
May 5, 2020
Merged

Add searchGalaxy icon#107
oliviacpu merged 3 commits intomasterfrom
ch9894

Conversation

@oliviacpu
Copy link
Copy Markdown
Contributor

We're doing some CSS tricks to switch out an SVG background and if this were in the icon set we could change props and do things in a more React-y way

Copy link
Copy Markdown
Contributor

@clottman clottman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like perhaps we should move at least the encoded <image> to a different file and import it, as it's adding quite a bit of clutter to this file.

Copy link
Copy Markdown
Contributor

@whimsicallyson whimsicallyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me! 👍

@oliviacpu oliviacpu merged commit 571fe8a into master May 5, 2020
@oliviacpu oliviacpu deleted the ch9894 branch May 5, 2020 18:21
@keithk
Copy link
Copy Markdown
Contributor

keithk commented Nov 10, 2020

🚀 PR was released in v0.19.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants