This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Update domain when initial name changes#108
Merged
modernserf merged 2 commits intomasterfrom May 7, 2020
Merged
Conversation
modernserf
commented
May 6, 2020
| export const StoryEditableProjectDomain = () => { | ||
| const [mockError, setMockError] = useState(false); | ||
| return ( | ||
| <> |
Contributor
Author
There was a problem hiding this comment.
everything below is just Prettier churn
clottman
approved these changes
May 6, 2020
Contributor
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EditableProjectDomain shared component does not "sync" -- i.e. when the domain in the header nav EditableProjectDomain changes, the domain on the page does not update, and vice versa. This PR fixes this behavior.