Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

Don't show the Results List if there's nothing to show yet#121

Merged
sheridanvk merged 3 commits intomasterfrom
obtainable-excessive-salary
Aug 13, 2020
Merged

Don't show the Results List if there's nothing to show yet#121
sheridanvk merged 3 commits intomasterfrom
obtainable-excessive-salary

Conversation

@sheridanvk
Copy link
Copy Markdown
Contributor

This is causing a blank box to appear under the search box when you click into it; this PR fixes it.

Before:
Screenshot 2020-08-12 at 12 00 37 PM

After:
Screenshot 2020-08-12 at 12 00 25 PM

See Search Results in obtainable-excessive-salary.glitch.me for a demo.

Glitch (shared-components) added 3 commits August 12, 2020 09:50
./lib/results-list.js:252452/1393
./lib/results-list.js:252452/412
./lib/search-results.js:252452/62
./lib/search-results.js:252452/30318
@sheridanvk sheridanvk requested a review from a team August 12, 2020 10:02
Copy link
Copy Markdown
Contributor

@keithk keithk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, nice!

@sheridanvk sheridanvk merged commit 7f3b420 into master Aug 13, 2020
@keithk
Copy link
Copy Markdown
Contributor

keithk commented Nov 10, 2020

🚀 PR was released in v0.19.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants