This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Update Styling to SearchResults component#126
Merged
Conversation
anjapatel
requested review from
a team and
pheebcodes
and removed request for
a team and
pheebcodes
keithk
approved these changes
Oct 16, 2020
| color: black; | ||
|
|
||
| ${ResultDescription} { | ||
| color: var(--colors-selected-secondary); |
Contributor
There was a problem hiding this comment.
After removing this variable does this look right on both light/dark mode?
Author
There was a problem hiding this comment.
Ohhh good catch. The background color #5a78ff is the same in both in both light and dark mode so it should be fine, and I didn't see anything strange when I checked @keithk
Contributor
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated some of the styling for the
SearchResultscomponent to match the Figma for the new private project overlay: https://www.figma.com/file/LLBMwcB37R4fQrn7kgZKUi/061820_PrivateProjects_MI%2BKAC?node-id=585%3A643Some things to note/outstanding questions:
Original search results list
New search results list. The blue results in the screenshots are the ones being hovered on!
It also looks like that white text on yellow isn't very accessible either — I can change that, or leave it since we don't use it anywhere and we'll be changing the shared component library anyway.