This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Run the styled components babel plugin, replace sucrase with babel#57
Merged
Run the styled components babel plugin, replace sucrase with babel#57
Conversation
added 5 commits
October 11, 2019 21:43
./package.json:97325/9794 ./rollup.config.js:97325/288
./rollup.config.js:97325/228
./package.json:97325/7
./rollup.config.js:97325/285 ./package.json:97325/3500
./package.json:97325/2
Contributor
Author
|
https://quixotic-rocket.glitch.me/ is a working community site with not hydration errors |
Contributor
|
can you bump the version and update the changelog on this? |
added 3 commits
October 16, 2019 14:45
./changelog.md:97325/150
Contributor
Author
|
Is anything else needed for this pr? |
modernserf
approved these changes
Oct 23, 2019
Contributor
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The styled components plugin doesn't work if anything else has transformed the code before it, so it needs to run in the shared components build step.
Additionally, the plugin's latest version doesn't transpile our code properly, so I've pinned it to the previous version.
I opted to remove sucrase in favor of running everything through babel, but it still works with sucrase handling the jsx transform if that's preferred.