Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

Enable running shared-components locally#62

Merged
clottman merged 5 commits intomasterfrom
run-locally
Nov 7, 2019
Merged

Enable running shared-components locally#62
clottman merged 5 commits intomasterfrom
run-locally

Conversation

@clottman
Copy link
Copy Markdown
Contributor

@clottman clottman commented Nov 4, 2019

  • adds dotenv so people working on this locally can set the port value in .env

  • replaces hard-coded app path with path.resolve(__dirname, ... so that the app can run on local machines as well as on Glitch

  • To test this locally while Glitch is down, comment out the glitchButton code in public/index.html.

  • Will create a remix with this branch on it when the site's back up.

@clottman clottman requested a review from modernserf November 4, 2019 20:18
@ehmorris ehmorris requested a review from a team November 7, 2019 15:09
Copy link
Copy Markdown
Contributor

@ehmorris ehmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked out this branch and ran the server locally and it worked!

To make the process easier for people checking out for the first time, I'd suggest adding a small section to the readme with the correct command to run. I'd also add a .sample.env file with the proper key to set the port, and a comment about it being optional, since locally you don't have the advantage of a special .env like you would on Glitch. I was unsure of the key name.

@clottman
Copy link
Copy Markdown
Contributor Author

clottman commented Nov 7, 2019

Updated readme, and got this running on glitch at ~boundless-olive to make sure it didn't break anything.

README.md Outdated

**TODO** explain how glitch remix / pull request flow works, use docs from community site

### Running off Glitch
Copy link
Copy Markdown
Contributor

@ehmorris ehmorris Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I might call this "Running Locally" but I don't have a strong preference.

@ttseng
Copy link
Copy Markdown
Contributor

ttseng commented Nov 7, 2019

awesome! it's working for me.

@clottman clottman merged commit 3fd39bf into master Nov 7, 2019
@clottman clottman deleted the run-locally branch November 7, 2019 17:07
@keithk
Copy link
Copy Markdown
Contributor

keithk commented Nov 10, 2020

🚀 PR was released in v0.19.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants