This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Merged
Conversation
./lib/overlay.js:9/18
Contributor
|
why remove the variable? it works in shared-components.glitch.me right? |
Contributor
Author
|
@sarahzinger it only works by accident... |
Contributor
|
gotcha, is there a way to make it work in the theme? https://github.com/FogCreek/shared-components/blob/bce898e28eb64e596387bb44a169193594bbdcd8/lib/themes.js#L17 maybe it has to be a string or something like that? |
./lib/overlay.js:9/52 ./lib/themes.js:9/30
Contributor
Author
|
good catch! |
sarahzinger
approved these changes
Nov 5, 2019
Contributor
sarahzinger
left a comment
sarahzinger
left a comment
There was a problem hiding this comment.
seems legit! are you able to test this with community to make sure it doesn't break our notifications/overlays?
./CONTRIBUTING.md:867163/125
Contributor
|
jk we don't use overlays or notifications in community so there'd be nothing to test |
Contributor
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a z-index to overlays (already did this with popovers)