This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Add ability to remove notifications#81
Merged
sheridanvk merged 2 commits intosheridan/ch8589/change-default-padding-for-notificationsfrom Feb 5, 2020
Conversation
sheridanvk
force-pushed
the
sheridan/ch8571/add-ability-to-remove-notifications
branch
from
7cdc208 to
5bde5cf
Compare
sheridanvk
force-pushed
the
sheridan/ch8571/add-ability-to-remove-notifications
branch
from
5bde5cf to
28dd8a0
Compare
sheridanvk
merged commit df3b307
into
sheridan/ch8589/change-default-padding-for-notifications
Contributor
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR puts
removeNotificationinto context so it can be used inside the NotificationProvider, and modifies thecreateNotificationfunction to return the notification (which includes its ID), such that the id can then later be used to remove the notification.Demo here:
https://glitch.com/edit/#!/equatorial-mushroom-a3p4w27vxl?path=lib/notification.js:1:0
I added a button "Remove Last Notification" into the Notification Story to demonstrate how to remove the last notification that was added.