This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Export the inputs from v0.14.3 & add 'adding a new component' docs#98
Merged
Export the inputs from v0.14.3 & add 'adding a new component' docs#98
Conversation
whimsicallyson
approved these changes
Mar 26, 2020
Contributor
whimsicallyson
left a comment
whimsicallyson
left a comment
There was a problem hiding this comment.
makes sense to me!
Contributor
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out new components don't get automatically exported for use in shared-components-the-npm-package; you need to add them to the lib/index.js exports
This PR exports/makes usable the components I released in PR #97.
Also, added docs on what to do when you want to add a new component