Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

Circle CI changes #99

Merged
clottman merged 5 commits intomasterfrom
test-should-build
Apr 15, 2020
Merged

Circle CI changes #99
clottman merged 5 commits intomasterfrom
test-should-build

Conversation

@clottman
Copy link
Copy Markdown
Contributor

Also do a build as part of test. Circle CI will automatically (with no config file defined, so by default) run npm run test so we can just jam more stuff we want to test in there for now, until it becomes necessary to have a real Circle CI config of our own.

@clottman
Copy link
Copy Markdown
Contributor Author

Lol, just kidding! Apparently running npm run test by default only happened when Keith created the workflow and won't happen again.
image

@clottman clottman marked this pull request as draft April 15, 2020 19:12
@clottman clottman marked this pull request as ready for review April 15, 2020 19:24
Copy link
Copy Markdown
Contributor

@oliviacpu oliviacpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 👍 Looks good and appears to work from the other PR! (#100)

@clottman
Copy link
Copy Markdown
Contributor Author

Also created #101 to show a demo of when linting fails.

@clottman clottman merged commit 80ac218 into master Apr 15, 2020
@keithk
Copy link
Copy Markdown
Contributor

keithk commented Nov 10, 2020

🚀 PR was released in v0.19.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants