This repository was archived by the owner on Jan 15, 2022. It is now read-only.
Add support for foreign currency sorting#265
Merged
glittershark merged 1 commit intoglittershark:masterfrom Mar 31, 2016
dis-aster-ous:foreign-currency-sort
Merged
Add support for foreign currency sorting#265glittershark merged 1 commit intoglittershark:masterfrom dis-aster-ous:foreign-currency-sort
glittershark merged 1 commit intoglittershark:masterfrom
dis-aster-ous:foreign-currency-sort
Conversation
Instead of assuming a string will start with a '$', this will filter any currency symbol before passing it to the numerical sort.
|
|
||
| switch (child.type) { | ||
| case _thead.Thead: | ||
| break; |
Contributor
Author
There was a problem hiding this comment.
not really sure why this happened...
Owner
There was a problem hiding this comment.
the build/ file gets out of sync all the time. Need to find a way to make Travis fail if that's the case.
Owner
|
Sweet, thanks! |
| ReactableTestUtils.expectRowText(10, ['a']); | ||
| ReactableTestUtils.expectRowText(11, ['z']); | ||
| }); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
this was the quickest way for me to get a breaking test. currently thinking of ways to optimize this, but for now it works. open to input, but otherwise i'll replace this commit once i think of something better.
Owner
|
TODO: need to split up that damn test file into multiple files so Babel doesn't truncate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of assuming a string will start with a '$', this will filter
any currency symbol before passing it to the numerical sort.