Skip to content

Fix Close race condition #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2020
Merged

Fix Close race condition #1

merged 1 commit into from
Sep 4, 2020

Conversation

@mbenford
Copy link
Collaborator

@mbenford mbenford commented Sep 4, 2020

Use a dedicated channel to signal the main loop to stop instead of relying on the order of Go's select statement.

@mbenford
Fix Close race condition
e818981 
Use a dedicated channel to signal the main loop to stop instead of
relying on the order of Go's select statement
@mbenford mbenford added the bug Something isn't working label Sep 4, 2020
@mbenford mbenford requested a review from rafaeleyng September 4, 2020 14:57
@rafaeleyng rafaeleyng merged commit ee91747 into master Sep 4, 2020
@rafaeleyng rafaeleyng deleted the fix-close-race-condition branch September 4, 2020 16:23
rafaeleyng
rafaeleyng reviewed Sep 4, 2020
View reviewed changes
Copy link
Contributor

@rafaeleyng rafaeleyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rafaeleyng rafaeleyng rafaeleyng left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mbenford @rafaeleyng