Fix error with plugins deactivation on install UI (#19774)

* Fix error with plugins deactivation on install UI

* Skip plugins deactivation if there is nothing to deactivate

* check table existence

Author: cedric-anne

src/Glpi/Kernel/KernelListenerTrait.php

@@ -34,6 +34,7 @@
 
 namespace Glpi\Kernel;
 
+use Config;
 use DBConnection;
 use Symfony\Component\HttpFoundation\Request;
 use Update;
@@ -77,6 +78,8 @@ protected function isSymfonyProfilerEndpoint(Request $request): bool
      */
     protected function isDatabaseUsable(): bool
     {
-        return DBConnection::isDbAvailable() && Update::isUpdateMandatory() === false;
+        return DBConnection::isDbAvailable()
+            && Config::isLegacyConfigurationLoaded()
+            && Update::isUpdateMandatory() === false;
     }
 }

src/Glpi/Kernel/Listener/PostBootListener/DisablePluginsOnVersionChange.php

@@ -34,7 +34,9 @@
 
 namespace Glpi\Kernel\Listener\PostBootListener;
 
+use Config;
 use DBConnection;
+use DBmysql;
 use Glpi\Debug\Profiler;
 use Glpi\Kernel\ListenersPriority;
 use Glpi\Kernel\PostBootEvent;
@@ -53,7 +55,15 @@ public static function getSubscribedEvents(): array
 
     public function onPostBoot(): void
     {
-        if (!DBConnection::isDbAvailable()) {
+        /** @var \DBmysql|null $DB */
+        global $DB;
+
+        if (
+            !DBConnection::isDbAvailable()
+            || !Config::isLegacyConfigurationLoaded()
+            || !($DB instanceof DBmysql)
+            || !$DB->tableExists(Plugin::getTable())
+        ) {
             return;
         }
 

src/Plugin.php

@@ -1218,6 +1218,10 @@ public function unactivateAll()
         /** @var \DBmysql $DB */
         global $DB;
 
+        if (countElementsInTable(static::getTable(), ['state' => self::ACTIVATED]) === 0) {
+            return;
+        }
+
         $DB->update(
             $this->getTable(),
             [