Skip to content

Allow the possibility to keep only some fields when converting to list#76

Merged
gluc merged 2 commits intogluc:devfrom
Tutuchan:dev
Sep 4, 2016
Merged

Allow the possibility to keep only some fields when converting to list#76
gluc merged 2 commits intogluc:devfrom
Tutuchan:dev

Conversation

@Tutuchan
Copy link
Copy Markdown

@Tutuchan Tutuchan commented Sep 2, 2016

Hi,

This PR adds a parameter to subset the fields when converting a Node to a list. I also added the relevant tests and fixed some of the existing ones (not() is deprecated in testthat and is firing a warning)

@codecov-io
Copy link
Copy Markdown

Current coverage is 92.18% (diff: 80.00%)

Merging #76 into dev will not change coverage

@@                dev        #76   diff @@
==========================================
  Files            15         15          
  Lines           973        973          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            897        897          
  Misses           76         76          
  Partials          0          0          

Powered by Codecov. Last update 7f69e6e...b8e82ea

@gluc gluc merged commit c9e81c7 into gluc:dev Sep 4, 2016
@gluc
Copy link
Copy Markdown
Owner

gluc commented Sep 4, 2016

Cool, highly appreciated!
There is a build failure on oldrel, but I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants