updating registries and files replacing space and underscore with dash#613
Merged
amarts merged 3 commits intogluster:masterfrom Nov 24, 2020
Merged
updating registries and files replacing space and underscore with dash#613amarts merged 3 commits intogluster:masterfrom
amarts merged 3 commits intogluster:masterfrom
Conversation
amarts
approved these changes
Nov 18, 2020
Member
|
Saw the below warnings. Should we fix them here and then merge ? Btw, PR looks good to me. Thanks for getting it done. |
Contributor
Author
371154f to
644a2d1
Compare
Contributor
Author
|
FYI this PR should be good now -- |
Member
|
URLs looking good now, but changed compared to before. For example, https://docs.gluster.org/en/latest/Administrator%20Guide/Setting%20Up%20Volumes/ is changed to https://docs.gluster.org/en/latest/Administrator-Guide/Setting-Up-Volumes/ Old references and Google search may brake for a few days(For example, an old URL mentioned in issues will get 404. Ref: #218) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is #447 rebased against master.
Marked as draft as I haven't yet had a chance to compile and make sure that everything works as expected; with such a large single commit I'd be surprised if my rebase is perfectly fine on the first try...