doc: update docs for volume options#638
Merged
sankarshanmukhopadhyay merged 3 commits intogluster:mainfrom Jan 29, 2021
Merged
Conversation
There are around 340+ options. I have included the most used, enabled by default, majorly affects the volumes or have been facing issues recently. The 1st patch deals with prefix 'cluster.' options. If I have missed any imp option please highlight or any unnecessary options is added. Owning to the huge list I move forward by creating a seperate md file for vol options. More commits to follow. Just divided to make review easy and quick. Updates: gluster#617 Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
Sheetalpamecha
requested review from
amarts,
sankarshanmukhopadhyay and
schaffung
schaffung
reviewed
Jan 25, 2021
amarts
reviewed
Jan 25, 2021
Member
amarts
left a comment
amarts
left a comment
There was a problem hiding this comment.
This is a much needed document. Thanks.
kshithijiyer
suggested changes
Jan 28, 2021
| | diagnostics.latency-measurement | Statistics related to the latency of each operation would be tracked. | Off | On/Off | ||
| | diagnostics.dump-fd-stats | Statistics related to file-operations would be tracked. | Off | On/Off | ||
| Performance | *features.trash | Enable/disable trash translator | off | on/off | ||
| | *performance.readdir-ahead | Enable/disable readdir-ahead translator in the volume | off | on/off |
Contributor
There was a problem hiding this comment.
Please remove the prefixed star
| | diagnostics.dump-fd-stats | Statistics related to file-operations would be tracked. | Off | On/Off | ||
| Performance | *features.trash | Enable/disable trash translator | off | on/off | ||
| | *performance.readdir-ahead | Enable/disable readdir-ahead translator in the volume | off | on/off | ||
| | *performance.read-ahead | Enable/disable read-ahead translator in the volume | off | on/off |
Contributor
There was a problem hiding this comment.
Please remove the prefixed star
| Performance | *features.trash | Enable/disable trash translator | off | on/off | ||
| | *performance.readdir-ahead | Enable/disable readdir-ahead translator in the volume | off | on/off | ||
| | *performance.read-ahead | Enable/disable read-ahead translator in the volume | off | on/off | ||
| | *performance.io-cache | Enable/disable io-cache translator in the volume | off | on/off |
Contributor
There was a problem hiding this comment.
Please remove the prefixed star
Member
Author
There was a problem hiding this comment.
These prefix are intentionally added. This is highlighted for below note in line100
| | diagnostics.client-log-level | Changes the log-level of the clients. | INFO | DEBUG/WARNING/ERROR/CRITICAL/NONE/TRACE | ||
| | diagnostics.latency-measurement | Statistics related to the latency of each operation would be tracked. | Off | On/Off | ||
| | diagnostics.dump-fd-stats | Statistics related to file-operations would be tracked. | Off | On/Off | ||
| Performance | *features.trash | Enable/disable trash translator | off | on/off |
Contributor
There was a problem hiding this comment.
Please remove the prefixed star at the start at *features.trash
Member
|
LGTM! Thank you for the focus on making the documents better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are around 340+ options.The 1st patch deals with prefix 'cluster.'
options. I have included the most used, enabled by default, majorly
affects the volumes or have been facing issues recently.
Owning to the huge list I move forward by creating a separate md
file for vol options. More commits to follow. Just divided to make
review easy and quick.
Updates: #617
Signed-off-by: Sheetal Pamecha spamecha@redhat.com