Skip to content

tests: ./tests/bugs/replicate/bug-921231.t is continuously failing#2006

Merged
mohit84 merged 1 commit intogluster:develfrom
mohit84:issue2005_devel
Jan 13, 2021
Merged

tests: ./tests/bugs/replicate/bug-921231.t is continuously failing#2006
mohit84 merged 1 commit intogluster:develfrom
mohit84:issue2005_devel

Conversation

@mohit84
Copy link
Contributor

@mohit84 mohit84 commented Jan 13, 2021

The test case (./tests/bugs/replicate/bug-921231.t )
is continuously failing.The test case is failing because
inodelk_max_latency is showing wrong value in profile.
The value is not correct because recently the profile
timestamp is changed from microsec to nanosec from
the patch #1833.

Fixes: #2005
Change-Id: Ieb683836938d986b56f70b2380103efe95657821
Signed-off-by: Mohit Agrawal moagrawa@redhat.com

@mohit84
Copy link
Contributor Author

mohit84 commented Jan 13, 2021

/run regression

@mohit84 mohit84 requested review from amarts and itisravi January 13, 2021 03:27
Copy link
Member

@amarts amarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

inodelk_max_latency=$($CLI volume profile $V0 info | grep INODELK | awk 'BEGIN {max = 0} {if ($6 > max) max=$6;} END {print max}' | cut -d. -f 1 | egrep "[0-9]{7,}")
inodelk_max_latency=$($CLI volume profile $V0 info | grep INODELK | awk 'BEGIN {max = 0} {if ($6 > max) max=$6;} END {print max}' | cut -d. -f 1 | egrep "[0-9]{9,}")
TEST [ -z $inodelk_max_latency ]

Copy link
Member

@itisravi itisravi Jan 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you share the values of $max and $inodelk_max_latency with and without your patch? Trying to understand the number manipulation here as the test always passes for me as it is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even i am not able to reproduce in softserve environment, it is failing on the regression server only.On regression server the value is showing
17:00:54 not ok 11 [ 3650/ 1] < 29> '[ -z 2796547 ]' -> ''
the test case is expecting value should be NULL

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could temporarily add a test in the .T to display the max value. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test case expects inodelk latency should be less than 1 sec so i have updated the test case. Earlier we print latency in microsec that's why test case used to ignore 7 digits now we are using nanosec so we have to ignore 10 digits.

The test case (./tests/bugs/replicate/bug-921231.t )
is continuously failing.The test case is failing because
inodelk_max_latency is showing wrong value in profile.
The value is not correct because recently the profile
timestamp is changed from microsec to nanosec from
the patch #1833.

Fixes: #2005
Change-Id: Ieb683836938d986b56f70b2380103efe95657821
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
@mohit84
Copy link
Contributor Author

mohit84 commented Jan 13, 2021

/run regression

Copy link
Member

@itisravi itisravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mohit84 mohit84 merged commit 90f18d1 into gluster:devel Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

./tests/bugs/replicate/bug-921231.t is continuously failing

3 participants