Skip to content

copy-file-range.t: handle ENOSYS#4111

Merged
mohit84 merged 1 commit intogluster:develfrom
xhernandez:devel.copy-file-range-enosys
Apr 20, 2023
Merged

copy-file-range.t: handle ENOSYS#4111
mohit84 merged 1 commit intogluster:develfrom
xhernandez:devel.copy-file-range-enosys

Conversation

@xhernandez
Copy link
Contributor

On some systems, the previous method to try to determine if copy_file_range() is supported was to check the symbol in /proc/kallsyms. However there are some cases where the symbol can be found, but still it's not supported, like if fuse doesn't implement it.

To avoid all possible combinations, just run the test normally and check for system call availability on first execution. If it's not there, just skip the remaining tests. Otherwise continue the test.

Updates: #4020

On some systems, the previous method to try to determine if
copy_file_range() is supported was to check the symbol in
/proc/kallsyms. However there are some cases where the symbol
can be found, but still it's not supported, like if fuse doesn't
implement it.

To avoid all possible combinations, just run the test normally and
check for system call availability on first execution. If it's not
there, just skip the remaining tests. Otherwise continue the test.

Updates: gluster#4020
Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>
@xhernandez
Copy link
Contributor Author

/run regression

@xhernandez xhernandez requested review from amarts and mohit84 April 19, 2023 11:10
@mohit84 mohit84 merged commit f7c6441 into gluster:devel Apr 20, 2023
@xhernandez xhernandez deleted the devel.copy-file-range-enosys branch April 20, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants