feat: add monitor assignment persistence during system sleep/resume #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for system sleep events in the window manager: - Introduced `SystemSleep` variant to `PlatformEvent` - Updated event handling in `wm.rs` to process system sleep events - Prepared `handle_system_sleep` function for future implementation
Member
|
Thank you for the PR! 🙌 Mentioned it on Discord, but our current approach ignores display changes during sleep, which should achieve the same result as storing/restoring monitor state on hibernate. If this PR does fix the issue, it's likely due to side effects rather than the monitor state feature itself - e.g., I notice it would skip the first display settings event after standby, which might be the actual solution. If that's the case, would you consider submitting a focused PR for just that approach instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #896