fix: handle transparency in mask-based icons for systray provider#198
Merged
lars-berger merged 1 commit intoglzr-io:mainfrom May 21, 2025
Merged
Conversation
Member
|
Thanks for fixing this! Both @HolbyFPV and I were trying to figure out this mask stuff but when one icon looked correct, it'd then break a different one. Apologies for getting around to reviewing this so late. I've been working on and off on a major v3 version bump which has a bunch of changes, but it's finally good to go. I'll get this PR included in a beta release of v3 later today. |
lars-berger
changed the title
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed there's an issue with transparency handling of old-school mask-based icons if there is a full black color involved.
In the original code if all the color channels are 0 (full black) it was treated as transparent which is incorrect.
I feel like removing this check will be a better option since we already establishing that we are dealing with mask-based icons beforehand with another check and there's only two possible values for those pixels - fully transparent (255) or opaque (everything else).
Before:
After:
Windows systray:
