Add property for indicator border width and color#23
Closed
hsin919 wants to merge 3 commits intogmarm:masterfrom
Closed
Add property for indicator border width and color#23hsin919 wants to merge 3 commits intogmarm:masterfrom
hsin919 wants to merge 3 commits intogmarm:masterfrom
Conversation
|
+1 |
Owner
|
Apologies for my late response, I didn't have much time lately. Why is a new |
Author
|
hi @gmarm Thanks for your feedback. The new UIView you mentioned is the Please feel free to change the variable name if you think it's not easy to understand. Thanks |
# Conflicts: # Pod/Classes/BetterSegmentedControl.swift
Author
|
Hi I just update the master to resolve the conflict. FYI. |
|
Thanks for adding the border. Keep it up |
Owner
|
The functionality has been added with a simpler implementation with #44. I'll be closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


An example above is also added to storyboard. It's made by new properties `indicatorBorderWidth` and `indicatorBorderColor`