Skip to content

Add property for indicator border width and color#23

Closed
hsin919 wants to merge 3 commits intogmarm:masterfrom
hsin919:master
Closed

Add property for indicator border width and color#23
hsin919 wants to merge 3 commits intogmarm:masterfrom
hsin919:master

Conversation

@hsin919
Copy link
Copy Markdown

@hsin919 hsin919 commented Aug 4, 2016

screen shot 2016-08-04 at 1 58 14 pm

An example above is also added to storyboard. It's made by new properties `indicatorBorderWidth` and `indicatorBorderColor`

@davidtperk
Copy link
Copy Markdown

+1

@gmarm
Copy link
Copy Markdown
Owner

gmarm commented Sep 14, 2016

Apologies for my late response, I didn't have much time lately.

Why is a new UIView needed for this? Why not simply set the IndicatorView's layer border properties?

@hsin919
Copy link
Copy Markdown
Author

hsin919 commented Sep 15, 2016

hi @gmarm Thanks for your feedback. The new UIView you mentioned is the borderView which is made for the other segments with different border color than the indicator one. For example we can set the indicator border to yellow and other segment's border to red with borderView's help as below.

screen shot 2016-09-15 at 2 18 29 pm

Please feel free to change the variable name if you think it's not easy to understand. Thanks

# Conflicts:
#	Pod/Classes/BetterSegmentedControl.swift
@hsin919
Copy link
Copy Markdown
Author

hsin919 commented Oct 3, 2016

Hi I just update the master to resolve the conflict. FYI.

@TheinHtikeAung
Copy link
Copy Markdown

Thanks for adding the border. Keep it up

@gmarm
Copy link
Copy Markdown
Owner

gmarm commented Dec 18, 2016

The functionality has been added with a simpler implementation with #44.

I'll be closing this.

@gmarm gmarm closed this Dec 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants