Conversation
JustShah
force-pushed
the
add-compliance-fields-to-address
branch
from
5c78a4b to
20f730e
Compare
fthobe
changed the title
JustShah
force-pushed
the
add-compliance-fields-to-address
branch
3 times, most recently
from
30b9a6d to
c81aace
Compare
fthobe
force-pushed
the
add-compliance-fields-to-address
branch
from
fdd1a75 to
1bccaea
Compare
fthobe
force-pushed
the
add-compliance-fields-to-address
branch
from
1bccaea to
1be1631
Compare
Enhances the Address model by introducing new attributes: email, vat_id, and reverse_charge_status. - **Enhanced Data Completeness**: Storing email and vat_id in the address model ensures that all relevant information is captured within the address record. - **Improved Tax Handling**: The reverse_charge_status enum provides better handling and flexibility for tax-related settings, aligning with various tax requirements and user needs.
Update the API components to include email, vat_id, and reverse_charge_status in the address attributes. Modified `Spree::ApiConfiguration` and `Spree::PermittedAttributes` to handle the new fields. These changes improve data completeness and tax handling by storing additional information in the address.
Update the admin address handling logic to include email, vat_id, and reverse_charge_status fields. Changes include updating form partials and views to handle these new fields, and modifying the JavaScript to process them.
JustShah
force-pushed
the
add-compliance-fields-to-address
branch
from
1be1631 to
0963b8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces enhancements to the address handling logic in both the admin and API components by incorporating additional fields: email, VAT ID, and reverse charge status. These changes aim to improve the completeness of address data and enhance tax handling capabilities.
Key Changes:
Admin Interface Updates:
API Enhancements:
Spree::ApiConfigurationto include email, VAT ID, and reverse charge status in the address attributes.Spree::PermittedAttributesto handle the new fields.address_books_spec.rbandcheckouts_spec.rb) to verify the handling of the new attributes.Address Model Improvements:
These changes enhance the functionality and completeness of the address handling logic by capturing additional relevant information and improving tax handling capabilities. The modifications ensure a more robust and flexible approach to managing address data within both the admin interface and the API.