fix: remove forwardPorts from feature schema#3
Merged
Conversation
The devcontainer feature schema (devcontainer-feature.json) doesn't allow forwardPorts or portsAttributes. These are devcontainer.json properties that users add to their own config. The publish action validates against the schema and rejects them. Move the port forwarding config into the README examples instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
devcontainer-feature.jsonschema doesn't allowforwardPortsorportsAttributes. These aredevcontainer.jsonproperties, not feature properties. The publish action validates against the schema and rejects them:The old v1.0.0 had the same invalid properties but was published before the action enforced schema validation.
Port forwarding instructions moved to the README examples, matching the pattern used by official features (sshd, desktop-lite, etc.).