fix: centralizing Meilisearch Api Key value #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this is centralizing Meilisearch API Key value into a single place
netlify.tomlRather than having it in multiple spots (toml config file and in the workflow deploying to Netlify)
Currently this has been done only for the variable:
MEILISEARCH_API_KEYWhich is likely to change or be rotated.
But it can be easily improved by adding all the others:
MEILISEARCH_URLMEILISEARCH_INDEX_UIDwhich are unlikely to be changed in this context.
Fixes #55