This repository was archived by the owner on Apr 4, 2022. It is now read-only.
[Explorer] Remove 'This project is in beta. Use at your own risk' message in footer #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matextrem
added
Enhancement
|
alfetopito
reviewed
Feb 7, 2022
Contributor
alfetopito
left a comment
alfetopito
left a comment
There was a problem hiding this comment.
Not convinced we should remove the element completely while leaving behind the config
Maybe we should just remove the flag || set isBeta to false by default in there?
|
@matextrem , LGTM from UI perspective, so I'm approving. |
elena-zh
approved these changes
Feb 8, 2022
elena-zh
suggested changes
Feb 8, 2022
There was a problem hiding this comment.
Hey @matextrem , now the footer needs to be enhanced in a mobile/tablet resolution after the latest commit
alfetopito
approved these changes
Feb 8, 2022
Contributor
alfetopito
left a comment
alfetopito
left a comment
There was a problem hiding this comment.
👍
Might just need to update how the component is rendered to avoid the issue Elena pointed out
alfetopito
approved these changes
Feb 9, 2022
matextrem
added
the
Auto-merge
Contributor
|
Oh, it was merged onto the release branch, which is already live. @matextrem please cherry-pick it onto |
matextrem
added a commit
that referenced
this pull request
Feb 10, 2022
…sage in footer (#1036) # Summary Closes #1035 Removed 'This project is in beta. Use at your own risk' message in footer  # To Test 1. Open any page. i.e: `Home` * You'll see the message 'This project is in beta. Use at your own risk' in footer has been removed.
matextrem
added a commit
that referenced
this pull request
Feb 10, 2022
…sage in footer (#1036) # Summary Closes #1035 Removed 'This project is in beta. Use at your own risk' message in footer  # To Test 1. Open any page. i.e: `Home` * You'll see the message 'This project is in beta. Use at your own risk' in footer has been removed.
Contributor
Author
|
@alfetopito Done! #1043 |
alfetopito
pushed a commit
that referenced
this pull request
Feb 14, 2022
…sage in footer (#1036) # Summary Closes #1035 Removed 'This project is in beta. Use at your own risk' message in footer  # To Test 1. Open any page. i.e: `Home` * You'll see the message 'This project is in beta. Use at your own risk' in footer has been removed.
This was referenced Apr 1, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1035
Removed 'This project is in beta. Use at your own risk' message in footer
To Test
Home