Retain and autorelease associated objects properly

[hmelder]

Apple's objc4 runtime expands the policy bits into the following
subcategories:

enum {
    OBJC_ASSOCIATION_SETTER_ASSIGN      = 0,
    OBJC_ASSOCIATION_SETTER_RETAIN      = 1,
    OBJC_ASSOCIATION_SETTER_COPY        = 3,
    OBJC_ASSOCIATION_GETTER_READ        = (0 << 8),
    OBJC_ASSOCIATION_GETTER_RETAIN      = (1 << 8),
    OBJC_ASSOCIATION_GETTER_AUTORELEASE = (2 << 8)
};

where

OBJC_ASSOCIATION_ASSIGN = 0
OBJC_ASSOCIATION_RETAIN_NONATOMIC = 1
OBJC_ASSOCIATION_COPY_NONATOMIC = 3
OBJC_ASSOCIATION_RETAIN = 01401
OBJC_ASSOCIATION_COPY = 01403 // No idea why this is in octal

This means that on OBJC_ASSOCIATION_{RETAIN, COPY} and the
NONATOMIC counterpart, we need to retain and autorelease the associated
object before returning it in objc_getAssociatedObject.

[davidchisnall]

The FreeBSD CI needs version bumping, can you add that s9 we can merge with clean CI?

[hmelder]

Do you know why libcxxrt_freebsd freebsd_instance:family/freebsd-13-3 and libcxxrt_freebsd freebsd_instance:family/freebsd-14-0 are still expected despite being deleted in .cirrus.yaml?

[davidchisnall]

Yes, the GitHub branch things are different.

[davidchisnall]

Looks like I can’t add them to the branch protection rules until the PR is merged.

[hmelder]

Looks like I can’t add them to the branch protection rules until the PR is merged.

And we cannot merge the PR without the being green. But it still waits for libcxxrt_freebsd freebsd_instance:family/freebsd-13-3.