Add some missing NSSearchPathDirectory enum types#442
Closed
buzzdeee wants to merge 1 commit intognustep:masterfrom
Closed
Add some missing NSSearchPathDirectory enum types#442buzzdeee wants to merge 1 commit intognustep:masterfrom
buzzdeee wants to merge 1 commit intognustep:masterfrom
Conversation
rfm
reviewed
Sep 16, 2024
Contributor
rfm
left a comment
rfm
left a comment
There was a problem hiding this comment.
While this looks relatively harmless, the fact that the new types are not implemented would cause potential confusion/breakage of apps that tried to use them, so I think it would be better to support those values in NSPathUtilities.m rather than ignoring them.
Contributor
|
I created rudimentary implementations for the directory types, so this patch is obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As found here: https://web.archive.org/web/20131113010445/https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundation/Miscellaneous/Foundation_Constants/Reference/reference.html