Conversation
Member
|
No apparent issues for me- |
fredkiefer
reviewed
Oct 17, 2021
Member
fredkiefer
left a comment
fredkiefer
left a comment
There was a problem hiding this comment.
I think this needs some rewrite. Are you going to look into this or should I handle it?
| } | ||
|
|
||
| - (BOOL) loadNibNamed: (NSString *)aNibName | ||
| owner: (id)owner |
Member
There was a problem hiding this comment.
The indentation looks wrong.
| { | ||
| NSDictionary *table = [NSDictionary dictionaryWithObject: owner forKey: NSNibOwner]; | ||
|
|
||
| success = [self loadNibFile: aNibName |
Member
There was a problem hiding this comment.
I think this method should be build on top of [NSNib instantiateWithOwner:topLevelObjects:] and the code over there should be corrected to follow the new memory management guidelines.
|
|
||
| if ([[path lastPathComponent] isEqualToString: @"obj"]) | ||
| { | ||
| path = [path stringByDeletingLastPathComponent]; |
Member
There was a problem hiding this comment.
Why do you change the value of path here? The new value never gets used. Either this is unnecessary or you should instantiate the NSBundle later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.