do not crash if passed rect as value is nil #344 #345
Conversation
|
@rfm are you satisfied with this fix (which is anyway safe and good, even if it maybe just hides the issue) or do you want to investigate the race condition further? |
rfm
left a comment
rfm
left a comment
There was a problem hiding this comment.
Yes, I have no problem with the fix; it's good defensive code to check for nil when using a method that returns a struct.
More fundamentally, we should probably remove the NSValue atExit code as it exists solely to avoid false positives with some memory leak checkers: I don't think asan or modern valgrind are subject to those false positives, and leak checkers generally support suppression lists to deal with false positives anyway.
The interesting thing would be to figure out how/why the NSView code is being called after the process exits. I suppose that might be due to some poor design of the way an app quits, but most likely it's really not important though.
for bug #344