refactor(handlers): consolidate client display conversion and remove magic strings

[appleboy]

Summary

• Extract shared clientToDisplay helper in utils.go, replacing duplicate appToDisplay and 2 inline OAuthApplication→ClientDisplay conversions across client.go and user_client.go
• Export ContextKeyClientIP constant from middleware/context.go, replacing 6 raw "client_ip" string occurrences across handlers, middleware, and tests
• Merge duplicate error page rendering in authorization.go:redirectWithError into a single conditional

Test plan

• All existing tests pass (go test ./...)
• Linter passes (make lint)
• Build succeeds (go build ./...)
• Verify login flow works (session fingerprint uses new constant)
• Verify OAuth callback flow works
• Verify admin client create/edit pages render correctly

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 3.33333% with 29 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
internal/handlers/utils.go	0.00%	19 Missing ⚠️
internal/handlers/user_client.go	0.00%	4 Missing ⚠️
internal/handlers/client.go	0.00%	2 Missing ⚠️
internal/handlers/auth.go	0.00%	1 Missing ⚠️
internal/handlers/authorization.go	0.00%	1 Missing ⚠️
internal/handlers/oauth_handler.go	0.00%	1 Missing ⚠️
internal/middleware/context.go	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

Refactors handler code to centralize OAuth client-to-template conversion logic and standardize the gin context key used to store the client IP, reducing duplication and removing hard-coded strings across the auth/session fingerprint flows.

Changes:

• Added a shared clientToDisplay helper in internal/handlers/utils.go and replaced duplicated OAuthApplication → ClientDisplay mappings in admin/user client handlers.
• Introduced middleware.ContextKeyClientIP and replaced raw "client_ip" usages in middleware, handlers, and tests.
• Simplified AuthorizationHandler.redirectWithError by merging duplicate error-page rendering branches.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
internal/middleware/context.go	Exports ContextKeyClientIP and uses it when storing client IP in gin context.
internal/middleware/auth.go	Uses ContextKeyClientIP when reading client IP for session fingerprinting.
internal/middleware/auth_test.go	Updates tests to set client IP using ContextKeyClientIP.
internal/handlers/utils.go	Adds shared clientToDisplay helper for template display mapping.
internal/handlers/client.go	Replaces inline client display mapping with clientToDisplay.
internal/handlers/user_client.go	Replaces appToDisplay and other conversions with clientToDisplay, removes duplicate helper.
internal/handlers/auth.go	Uses middleware.ContextKeyClientIP when generating login session fingerprint.
internal/handlers/oauth_handler.go	Uses middleware.ContextKeyClientIP when generating OAuth callback session fingerprint.
internal/handlers/authorization.go	Consolidates redirect error handling into a single conditional branch.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.