fix(middleware): sliding expiration for remember-me sessions#117
Closed
Copilot wants to merge 2 commits intoworktree-loginfrom
Closed
fix(middleware): sliding expiration for remember-me sessions#117Copilot wants to merge 2 commits intoworktree-loginfrom
Copilot wants to merge 2 commits intoworktree-loginfrom
Conversation
7 tasks
…e branch for sliding expiration Co-authored-by: appleboy <21979+appleboy@users.noreply.github.com> Agent-Logs-Url: https://github.com/go-authgate/authgate/sessions/1b762db8-27ed-4ba9-8c37-5e2b4f88c6bb
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add remember-me checkbox for 30-day sessions
fix(middleware): sliding expiration for remember-me sessions
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SessionIdleTimeoutupdatedSessionLastActivityin the remember-me branch but never calledsession.Save(), so the cookie expiration never actually slid—only the in-memory value changed.Changes
SessionIdleTimeout— addsession.Save()after updatingSessionLastActivityin the remember-me branch, so the cookie is rewritten on every requestTestSessionIdleTimeout_RememberMeUpdatesLastActivity— assertSet-Cookieis present in the response, verifyingsession.Save()was called (not just the in-memory value)⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.