refactor(services): split client.go user methods into client_user.go#126
Merged
refactor(services): split client.go user methods into client_user.go#126
Conversation
- Extract UserUpdateClientRequest struct into client_user.go - Extract validateUserScopes, ListClientsByUser into client_user.go - Extract UserUpdateClient, UserDeleteClient into client_user.go - Keep admin methods, shared types, and helpers in client.go Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the ClientService implementation by extracting non-admin user self-service client operations into a dedicated client_user.go file, matching the existing test split and keeping client.go focused on the broader/admin-capable surface.
Changes:
- Moved
UserUpdateClientRequestintointernal/services/client_user.go. - Moved user self-service methods (
ListClientsByUser,UserUpdateClient,UserDeleteClient) and helper (validateUserScopes) intoclient_user.go. - Removed the relocated definitions from
internal/services/client.go(no functional changes).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/services/client_user.go | New file containing user self-service client management types/helpers/methods. |
| internal/services/client.go | Removes the user self-service code that was relocated to client_user.go. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/services/client.gointoclient_user.goclient.goreduced from 755 → 594 lines;client_user.gois 174 linesclient_test.go+client_user_test.go)Moved to
client_user.goUserUpdateClientRequestvalidateUserScopes()ListClientsByUser()UserUpdateClient()UserDeleteClient()Test plan
make build— full build passesmake test— all tests passmake lint— 0 issues🤖 Generated with Claude Code