feat(config): make JWT expiration configurable via environment variable#135
Merged
feat(config): make JWT expiration configurable via environment variable#135
Conversation
- Replace hardcoded 1-hour JWT expiration with configurable JWT_EXPIRATION env var - Add validation to reject zero or negative duration values at startup - Add tests for env var parsing, default value, and validation rules - Update existing config tests to include JWTExpiration field Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JWTExpirationwith configurableJWT_EXPIRATIONenv var (supports5m,1h,30setc.)Changes
internal/config/config.go: UsegetEnvDuration("JWT_EXPIRATION", time.Hour)instead of hardcodedtime.Hour; add validation inValidate()internal/config/config_test.go: AddJWTExpirationto all existing test configs; add new tests for env var parsing, default value, and validationTest plan
make test— all config tests passmake lint— 0 issuesJWT_EXPIRATION=5m ./bin/authgate serveruses 5-minute token expiryJWT_EXPIRATIONdefaults to 1 hour🤖 Generated with Claude Code