refactor(ui): extract shared search & filter toolbar component#144
Merged
refactor(ui): extract shared search & filter toolbar component#144
Conversation
- Extract sf-toolbar CSS from account-sessions.css into shared components/search-filter-toolbar.css - Create SfToolbar, SfSearchRow, and SfFilterTab reusable templ components with SfSearchRowProps configuration - Migrate account sessions, admin clients, my apps, and audit logs pages to use the shared toolbar pattern - Remove deprecated ClientsSearchBar, SessionsFilterTab, and AdminClientsStatusTab components - Clean up unused CSS classes from search.css, admin-clients.css, and admin-audit-logs.css - Use templ.Classes for dotClass sanitization to prevent XSS - Sort hidden field keys for deterministic HTML output Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sf-toolbarsearch + filter toolbar from the sessions page into reusable shared components (SfToolbar,SfSearchRow,SfFilterTab)ClientsSearchBar,SessionsFilterTab,AdminClientsStatusTab) and unused CSSChanges
New files:
search_filter_toolbar_component.templ— 3 composable templ components +SfSearchRowPropsin props.gocomponents/search-filter-toolbar.css— shared sf-* CSS extracted from account-sessions.cssMigrated pages:
/account/sessions— usesSfToolbar+SfSearchRow+SfFilterTab(Status + Type tabs)/admin/clients— replacedstatus-filter-tabs+ClientsSearchBarwith sf-toolbar segmented tabs/apps— replacedClientsSearchBarwithSfToolbar+SfSearchRow/admin/audit— wrapped inSfToolbar, uses sf-* CSS classes inline (advanced filters need single form)Security hardening:
templ.Classes()for dot-class sanitization instead of raw string concatenationTest plan
make generate && make build && make lintpass (verified)🤖 Generated with Claude Code