feat(ui): add scope restriction notice for user app form#152
Conversation
- Add info notice in scope picker explaining that user-registered apps are limited to standard scopes - Extract .admin-info-notice into a proper CSS class, replacing inline styles in user_app_form.templ Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a user-facing notice in the shared client scope picker to clarify that user-registered apps are limited to preset/standard scopes, and refactors the existing “admin approval required” notice styling to use a reusable CSS class.
Changes:
- Added a conditional info notice above the scope picker when
ScopePresetsOnlyis enabled (user app form path). - Extracted the previously inline-styled “admin approval required” notice into a reusable
.admin-info-noticeCSS class. - Applied
.admin-info-noticeto the user app “pending approval” notice.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/templates/user_app_form.templ | Removes inline styles and uses the shared .admin-info-notice class for the pending-approval notice. |
| internal/templates/static/css/pages/admin-forms.css | Introduces the .admin-info-notice class to centralize notice styling. |
| internal/templates/client_shared.templ | Adds a conditional scope restriction notice shown only when ScopePresetsOnly is true (user app form). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
.admin-info-noticeinto a proper CSS class inadmin-forms.css, replacing the inline styles previously used inuser_app_form.templTest plan
/apps→ "Register New App" and verify the blue info notice appears above the scope picker/apps/:id/editand verify the notice also appears on the edit form/admin/clients/newand verify the notice does NOT appear (admin form allows custom scopes)🤖 Generated with Claude Code