feat(admin): show full name beside username in client authorizations

[appleboy]

Summary

The admin client authorizations view (/admin/clients/:id/authorizations) showed only each authorizing user's username. This PR adds the user's full name in parentheses beside it — username (fullname) — so admins can identify users at a glance. When a user has no full name, the display falls back to username alone.

The User model already stored FullName; it simply wasn't carried into this view. This PR threads it through the existing chain.

AI Authorship

• No AI was used in this PR
• AI was used. Details:
  • Tool / model: Claude Opus 4.7 (1M context) via Claude Code
  • AI-authored files: all 5 changed files
  • Human line-by-line reviewed: none yet — reviewer attention requested

Change classification

• Leaf node (local impact) — a single read-only admin view. No change to auth, token issuance, schema, or any shared path. Worst case is a cosmetic rendering issue on one page.
• Core code

Plan reference

No plan.md. Goal: show username (fullname) instead of bare username in the client authorizations User column, gracefully omitting the parenthetical when no full name exists.

Verification

• Unit tests — added TestListClientAuthorizations_ResolvesUserDetails covering a user with a full name (resolves Username + FullName + Email) and a user without one (FullName stays empty)
• Existing ListClientAuthorizations tests still pass
• Stress / soak test: N/A
• Also verified: make generate (clean), make fmt (clean), make build (OK), make lint (0 issues)
• Manual verification for reviewer: open /admin/clients/<id>/authorizations for a client with consenting users; confirm users with a full name render username (fullname) and users without one render just username. The generated templ emits a literal space, so it reads alice (Alice Anderson), not alice(Alice Anderson).

Verifiability check

• Inputs/outputs documented — service view-model field FullName flows handler → props → template
• Reviewer can judge correctness from the one-field addition across the four layers plus the new test
• Failures would surface as a visible rendering difference on the page / in the test

Risk & rollback

• Risk: Minimal. Read-only display change on one admin page; no data, schema, or behavior changes. The parenthetical is conditional, so an empty FullName can't produce stray ().
• Rollback: Single commit — git revert or close the PR. No migrations.

Reviewer guide

• Read carefully: internal/templates/admin_client_authorizations.templ — the conditional render (confirm the space between username and the parenthetical) — and internal/services/authorization.go — FullName population in ListClientAuthorizations.
• Spot-check OK: internal/handlers/client.go, internal/templates/props.go (one-field plumbing), and the new test in internal/services/authorization_test.go.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Adds FullName to the admin client authorizations view-model pipeline so the UI can render username (full name) for easier user identification, with a graceful fallback when the full name is empty.

Changes:

• Extend the client-authorization display models (UserAuthorizationWithUser, ClientAuthorizationDisplay) to include FullName.
• Thread FullName through service → handler → template rendering for /admin/clients/:id/authorizations.
• Add a unit test to verify user detail resolution (username/full name/email) for users with and without a full name.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/templates/props.go	Adds FullName to the admin authorizations view model.
internal/templates/admin_client_authorizations.templ	Renders full name in parentheses next to username when present.
internal/services/authorization.go	Populates FullName when resolving user details for client authorizations.
internal/services/authorization_test.go	Adds test coverage for resolved user details (including full name).
internal/handlers/client.go	Plumbs FullName into template props for the admin authorizations page.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
internal/handlers/client.go	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.