refactor(cli): fix timer leak, remove dead code, and consolidate error parsing#27
Merged
refactor(cli): fix timer leak, remove dead code, and consolidate error parsing#27
Conversation
…r parsing - Replace time.After with time.NewTimer in callback server to prevent goroutine leak - Remove unnecessary time.Sleep calls in browser and device flow error paths - Remove unused functions: GetFloat64, FlowUpdateType.String, FormatDurationCompact, FormatInterval - Extract parseOAuthError helper to consolidate triplicated error unmarshaling - Delegate error formatting in doTokenExchange to formatHTTPError Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time.Aftertimer leak in callback server — replaced withtime.NewTimer+defer timer.Stop()to prevent 2-minute goroutine leaks on every successful OAuth callbacktime.Sleep(100ms)in browser flow and device flow error paths — the buffered channel and consumer drain loops already ensure updates are processedGetFloat64,FlowUpdateType.String(),FormatDurationCompact,FormatInterval) and their associated test codeparseOAuthErrorhelper to consolidate triplicated OAuth error JSON unmarshaling acrossformatHTTPError,doTokenExchange, andhandleDevicePollErrordoTokenExchangetoformatHTTPErrorto eliminate duplicate formatting logicTest plan
make test)make lint)make fmt)🤖 Generated with Claude Code