Skip to content

chore: sync deps, fix lint issues, standardize CI#24

Merged
ankurs merged 4 commits intomainfrom
chore/update-03-2026
Mar 21, 2026
Merged

chore: sync deps, fix lint issues, standardize CI#24
ankurs merged 4 commits intomainfrom
chore/update-03-2026

Conversation

@ankurs
Copy link
Copy Markdown
Member

@ankurs ankurs commented Mar 21, 2026

Summary

  • Update tracing dependency v0.0.6 to v0.0.7
  • Fix capitalized error strings (ErrWTF, ErrInvalidBuilder)
  • Upgrade golangci.yml from v1 to v2 format
  • Standardize CI with separate build/test/lint jobs

Test plan

  • make build passes
  • make test passes (with -race)
  • make lint passes with 0 issues

- Update tracing dependency v0.0.6 to v0.0.7
- Fix capitalized error strings (ErrWTF, ErrInvalidBuilder)
- Upgrade golangci.yml from v1 to v2 format
- Standardize CI with separate build/test/lint jobs
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 21, 2026

Warning

Rate limit exceeded

@ankurs has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 17 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1859c33d-a17a-4b9b-ba78-2fdf1b0ae811

📥 Commits

Reviewing files that changed from the base of the PR and between b0c74ee and 8a1f832.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (6)
  • .github/workflows/go.yml
  • .golangci.yml
  • Makefile
  • go.mod
  • plan.go
  • types.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/update-03-2026

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the project’s dependency and CI/lint setup by bumping the tracing module, aligning error strings with Go conventions, migrating golangci-lint config to the v2 schema, and splitting GitHub Actions into dedicated build/test/lint jobs.

Changes:

  • Bump github.com/go-coldbrew/tracing from v0.0.6 to v0.0.7.
  • Normalize error strings to start lowercase (e.g., ErrInvalidBuilder, ErrWTF).
  • Upgrade .golangci.yml to v2 format and restructure CI into separate build/test/lint jobs.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
types.go Lowercases ErrInvalidBuilder message to match Go error-string style.
plan.go Lowercases ErrWTF message.
go.mod Updates tracing dependency version.
Makefile Adds lint/bench to .PHONY; adjusts lint target invocation behavior.
.golangci.yml Migrates golangci-lint configuration to v2 schema.
.github/workflows/go.yml Splits CI into separate build/test/lint jobs and routes build/test via make.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile Outdated
Comment thread Makefile Outdated
Comment thread plan.go Outdated
- Add permissions: contents: read to CI workflow
- Fix bench target to skip regular tests (-run=^$)
- Fix ErrWTF doc comment consistency
- Add install and test-v to .PHONY
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Pin actions/checkout, actions/setup-go, golangci-lint-action to commit SHAs
- Replace hardcoded go-version with go-version-file: go.mod
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plan.go Outdated
- Make lint target reproducible (go install golangci-lint)
- Add missing tests and strengthen assertions
- Fix error string grammar
@ankurs ankurs merged commit f538299 into main Mar 21, 2026
5 checks passed
@ankurs ankurs deleted the chore/update-03-2026 branch March 21, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants