chore: sync deps, fix lint issues, standardize CI#24
Conversation
- Update tracing dependency v0.0.6 to v0.0.7 - Fix capitalized error strings (ErrWTF, ErrInvalidBuilder) - Upgrade golangci.yml from v1 to v2 format - Standardize CI with separate build/test/lint jobs
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR modernizes the project’s dependency and CI/lint setup by bumping the tracing module, aligning error strings with Go conventions, migrating golangci-lint config to the v2 schema, and splitting GitHub Actions into dedicated build/test/lint jobs.
Changes:
- Bump
github.com/go-coldbrew/tracingfromv0.0.6tov0.0.7. - Normalize error strings to start lowercase (e.g.,
ErrInvalidBuilder,ErrWTF). - Upgrade
.golangci.ymlto v2 format and restructure CI into separate build/test/lint jobs.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
types.go |
Lowercases ErrInvalidBuilder message to match Go error-string style. |
plan.go |
Lowercases ErrWTF message. |
go.mod |
Updates tracing dependency version. |
Makefile |
Adds lint/bench to .PHONY; adjusts lint target invocation behavior. |
.golangci.yml |
Migrates golangci-lint configuration to v2 schema. |
.github/workflows/go.yml |
Splits CI into separate build/test/lint jobs and routes build/test via make. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add permissions: contents: read to CI workflow - Fix bench target to skip regular tests (-run=^$) - Fix ErrWTF doc comment consistency - Add install and test-v to .PHONY
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Pin actions/checkout, actions/setup-go, golangci-lint-action to commit SHAs - Replace hardcoded go-version with go-version-file: go.mod
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Make lint target reproducible (go install golangci-lint) - Add missing tests and strengthen assertions - Fix error string grammar
Summary
Test plan
make buildpassesmake testpasses (with -race)make lintpasses with 0 issues