Skip to content

Ensure we update the result for all builders that do not have errors #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Ensure we update the result for all builders that do not have errors #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion plan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ func doWorkAndGetResult(ctx context.Context, builders []*builder, dataMap map[st
}
wg.Wait() // wait for work to be processed
close(outChan)
errs := make([]error, 0)
for o := range outChan {
if o.err != nil {
return o.err
Expand All @@ -172,12 +173,18 @@ func doWorkAndGetResult(ctx context.Context, builders []*builder, dataMap map[st
// 0-> data, 1-> error
if !outputs[1].IsNil() {
// error occured, return it back and stop processing
return outputs[1].Interface().(error)
errs = append(errs, outputs[1].Interface().(error))
continue
}
// add result
name := getStructName(outputs[0].Type())
dataMap[name] = outputs[0].Interface()
}
if len(errs) > 0 {
// we only return the first error
// TODO enhance error handling
return errs[0]
}
return nil
}

Expand Down