docs: add distributed tracing section to production deployment guide#45
docs: add distributed tracing section to production deployment guide#45
Conversation
Add comprehensive tracing section covering: - OTLP backend setup (Jaeger, Tempo, Honeycomb, etc.) - New Relic OpenTelemetry configuration - What gets traced automatically (gRPC RPCs, HTTP, custom spans) - Sampling ratio recommendations by QPS - Parent-based sampling note - OTLP auth headers in secrets example
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughDocumentation extended with a new production deployment guide covering Kubernetes setup, health probes, distributed tracing via OpenTelemetry/OTLP and New Relic, and graceful shutdown. Navigation links to this guide were added to index and quickstart pages. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds a dedicated distributed tracing section to the Production Deployment guide so operators have concrete OTLP/New Relic setup guidance alongside existing production Kubernetes recommendations.
Changes:
- Updates page metadata/description to include distributed tracing.
- Extends the example Kubernetes Secret with
OTLP_HEADERS(for OTLP backend auth headers). - Adds a new “Distributed tracing” section covering OTLP + New Relic configuration, traced span sources, and production sampling guidance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | 100 | `1.0` | 100 | | ||
| | 1,000 | `0.1` | 100 | | ||
| | 10,000 | `0.01` | 100 | | ||
| | 70,000+ | `0.001–0.01` | 70–700 | |
There was a problem hiding this comment.
The “Recommended ratio” cell uses inline-code to show a range (0.001–0.01). Since OTLP_SAMPLING_RATIO is a single float, readers may copy/paste the range literally and end up with an invalid value. Consider expressing this as plain text (e.g., “0.001 to 0.01”) or splitting into min/max guidance.
| | 70,000+ | `0.001–0.01` | 70–700 | | |
| | 70,000+ | 0.001 to 0.01 | 70–700 | |
| - name: OTLP_ENDPOINT | ||
| value: "api.honeycomb.io:443" | ||
| - name: OTLP_HEADERS | ||
| value: "x-honeycomb-team=your-api-key" |
There was a problem hiding this comment.
This example includes an API key inline in the manifest (OTLP_HEADERS: "x-honeycomb-team=your-api-key"). Elsewhere on this page you recommend putting secrets in Kubernetes Secrets; consider showing valueFrom.secretKeyRef here (or explicitly noting the header value should come from a Secret) to avoid encouraging in-repo/plaintext configs.
| value: "x-honeycomb-team=your-api-key" | |
| valueFrom: | |
| secretKeyRef: | |
| name: myservice-secrets | |
| key: OTLP_HEADERS |
|
|
||
| ### New Relic | ||
|
|
||
| New Relic tracing is configured separately and can run alongside OTLP: |
There was a problem hiding this comment.
The text says “New Relic tracing … can run alongside OTLP”, but the config reference states that when OTLP_ENDPOINT is set it takes precedence over New Relic OpenTelemetry configuration. This is internally inconsistent and could confuse users about whether traces are dual-exported. Please clarify the precedence/interaction here (or link to the canonical behavior) so the guide matches the config reference.
| New Relic tracing is configured separately and can run alongside OTLP: | |
| New Relic tracing is configured separately. It can be enabled in the same service as OTLP, but when `OTLP_ENDPOINT` is set it takes precedence over the New Relic OpenTelemetry exporter, so traces are not dual-exported. See the [config reference](/config-reference#distributed-tracing) for details: |
Summary
The production deployment guide had no dedicated tracing section — just a one-line mention in the checklist. Add comprehensive coverage:
Test plan
Summary by CodeRabbit
Documentation