chore: upgrade just-the-docs v0.5→v0.10.1, fix SEO, widen content#61
chore: upgrade just-the-docs v0.5→v0.10.1, fix SEO, widen content#61
Conversation
…t area - Upgrade just-the-docs theme from v0.5.0 to v0.10.1 (Jekyll 4.3→4.4.1) - Migrate GA tracking from deprecated ga_tracking config to custom head include - Fix repository config and baseurl for correct local/production builds - Fix 3 short meta descriptions (integrations, gRPC, Metrics) to 120+ chars - Eliminate duplicate nav_order (architecture + config-reference both had 5) - Renumber all top-level page nav_order values for contiguous sidebar ordering - Add nav_order to all 16 howto child pages for deterministic sidebar order - Create explicit robots.txt with production sitemap URL - Widen main content area from 50rem (800px) to 66rem (1056px) - Fix Playwright strict mode violations in content tests
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 14 minutes and 51 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR reorders many docs via Jekyll front-matter Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Upgrades the docs site theme (just-the-docs) and adjusts site configuration/content to restore SEO correctness, improve navigation ordering, and update tests/layout for the new theme version.
Changes:
- Upgraded just-the-docs to v0.10.1 (and Jekyll dependency set via lockfile), plus config updates (repository/baseurl) and GA moved to a custom head include.
- SEO/navigation improvements: longer meta descriptions, consistent/complete
nav_orderacross top-level + How To children, and a generatedrobots.txtwith sitemap link. - Layout/test updates: widen content area via Sass variable and fix Playwright strict-mode selector behavior.
Reviewed changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/content.spec.ts |
Makes content lookups strict-mode-safe by selecting the first matching main container. |
robots.txt |
Adds a Jekyll/Liquid-rendered robots file with a sitemap URL. |
Packages.md |
Adjusts top-level nav ordering. |
integrations.md |
Expands meta description and adjusts nav ordering. |
howto/index.md |
Adjusts How To section ordering. |
howto/APIs.md |
Adds nav_order for How To child ordering. |
howto/gRPC.md |
Adds nav_order and expands description. |
howto/Log.md |
Adds nav_order for How To child ordering. |
howto/errors.md |
Adds nav_order for How To child ordering. |
howto/Tracing.md |
Adds nav_order for How To child ordering. |
howto/Metrics.md |
Adds nav_order and expands description. |
howto/interceptors.md |
Adds nav_order for How To child ordering. |
howto/Debugging.md |
Adds nav_order for How To child ordering. |
howto/signals.md |
Adds nav_order for How To child ordering. |
howto/swagger.md |
Adds nav_order for How To child ordering. |
howto/data-builder.md |
Adds nav_order for How To child ordering. |
howto/vtproto.md |
Adds nav_order for How To child ordering. |
howto/production.md |
Adds nav_order for How To child ordering. |
howto/testing.md |
Adds nav_order for How To child ordering. |
howto/workers.md |
Adds nav_order for How To child ordering. |
howto/private-modules.md |
Adds nav_order for How To child ordering. |
FAQ.md |
Adjusts top-level nav ordering. |
config-reference.md |
Adjusts top-level nav ordering. |
architecture.md |
Adjusts top-level nav ordering. |
Gemfile |
Bumps just-the-docs version requirement. |
Gemfile.lock |
Updates locked Ruby dependencies for Jekyll/just-the-docs upgrade. |
_sass/custom/setup.scss |
Widens main content area by overriding theme Sass variable. |
_includes/head_custom.html |
Injects GA tag via just-the-docs head customization hook. |
_config.yml |
Fixes baseurl/repository and removes deprecated GA config key. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/content.spec.ts (1)
87-88: Consider unifying selector patterns across test files.The fix is correct. However,
navigation.spec.tsuses#main-content, .main-content, main(three selectors, ID-first) while this file usesmain, .main-content(two selectors, element-first). Unifying these patterns would improve maintainability if the DOM structure changes again.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/content.spec.ts` around lines 87 - 88, Unify the selector pattern used in tests by changing the locator call that assigns pageText (page.locator(...)) to use the same selector list as navigation.spec.ts ("#main-content, .main-content, main") instead of the current "main, .main-content"; update the page.locator invocation in tests/content.spec.ts (the code that produces pageText) so it uses the ID-first, class, element order to keep patterns consistent across test files.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Gemfile`:
- Line 4: The Gemfile currently uses gem "just-the-docs", "0.10.1" which pulls a
public_suffix requiring Ruby >= 3.2 and breaks CI running Ruby 3.1; fix by
either updating your CI jobs to use Ruby 3.2+ in the GitHub Actions workflow
files (playwright.yml and jekyll.yml) or pinning the older public_suffix in the
Gemfile by adding a line to constrain public_suffix to "< 7.0" so bundle install
succeeds under Ruby 3.1.
---
Nitpick comments:
In `@tests/content.spec.ts`:
- Around line 87-88: Unify the selector pattern used in tests by changing the
locator call that assigns pageText (page.locator(...)) to use the same selector
list as navigation.spec.ts ("#main-content, .main-content, main") instead of the
current "main, .main-content"; update the page.locator invocation in
tests/content.spec.ts (the code that produces pageText) so it uses the ID-first,
class, element order to keep patterns consistent across test files.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cdf53714-815e-4a71-be60-dd1595caaf7b
⛔ Files ignored due to path filters (1)
Gemfile.lockis excluded by!**/*.lock
📒 Files selected for processing (28)
FAQ.mdGemfilePackages.md_config.yml_includes/head_custom.html_sass/custom/setup.scssarchitecture.mdconfig-reference.mdhowto/APIs.mdhowto/Debugging.mdhowto/Log.mdhowto/Metrics.mdhowto/Tracing.mdhowto/data-builder.mdhowto/errors.mdhowto/gRPC.mdhowto/index.mdhowto/interceptors.mdhowto/private-modules.mdhowto/production.mdhowto/signals.mdhowto/swagger.mdhowto/testing.mdhowto/vtproto.mdhowto/workers.mdintegrations.mdrobots.txttests/content.spec.ts
- robots.txt: add layout: null and sitemap: false to prevent HTML wrapping - head_custom.html: guard GA snippet with jekyll.environment == production - CI workflows: upgrade Ruby 3.1 → 3.2 (public_suffix 7.x requires >= 3.2)
Summary
ga_trackingto custom_includes/head_custom.html, fixedrepositoryandbaseurlconfignav_order, renumbered all top-level pages, addednav_orderto all 16 howto child pages, created explicitrobots.txtwith production sitemap URL_sass/custom/setup.scssTest plan
bundle exec jekyll buildsucceeds without errorsnpx playwright test)robots.txtcontainshttps://docs.coldbrew.cloud/sitemap.xmlSummary by CodeRabbit
New Features
Chores