Bug: Cross-Compile corrupts other builds

[JasCodes]

@jld3103

When I build one platform, the other folders gets updated and corrupted. Not sure whats happening but on ubuntu platfrom.

[ERROR:flutter/shell/platform/embedder/embedder.cc(629)] 
Not running in AOT mode but could not resolve the kernel binary.
[ERROR:flutter/shell/platform/embedder/embedder.cc(53)]
Returning error 'kInvalidArguments' (2) from Flutter Embedder API call 
to 'FlutterEngineRun'. 
Origin: ../../flutter/shell/platform/embedder/embedder.cc:631
go-flutter: engine.Run() returned result code 2 (invalid arguments)

Let me know if you guys can reproduce this?

Flutter version

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v1.10.7-pre.70, on Linux, locale en_US.UTF-8)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 3.5)
[✓] Android Studio (version 3.4)
[✓] VS Code (version 1.36.0)
[✓] Connected device (3 available)

[pchampio]

For what it is worth:
Can you share the content of your go directory, ls -R ./go?

[pchampio]

Sometimes I get this error, and re-running the hover command solve the problem.
Have you found a reproducible path/route to always get this issue?
If yes, then please share the commands you used!

[provokateurin]

That's not a hover bug it's a bug in flutter that has already been fixed. Just update.

[provokateurin]

This was the original bug report: flutter/flutter#41352

[JasCodes]

@jld3103 I have upgraded but still facing issue. I have created script for now to zip the output platform folder. But when I build one platform, the old builts of other platforms get corrupted. I don't know how?

I will double check non the less.

[provokateurin]

I'll try to reproduce this scenario (I'm on linux):

1. Build and run linux - Should be fine
2. Build and run windows (with wine) - Should be fine
3. Run linux again - Should crash

@JasCodes Is this the scenario you described?

EDIT: Bug confirmed!

[provokateurin]

The problem seems that all files in flutter_assets are deleted. The folders remain

[JasCodes]

@jld3103

@JasCodes Is this the scenario you described?

Exactly..

[provokateurin]

Looks like only one flutter bundle can be stored at a time (Why?). So just moving the bundle to one location for all builds and then copying it over should do the thing.

[provokateurin]

@JasCodes @Drakirus can you confirm my fix to be working?

[pchampio]

@jld3103 on the following flutter version:

Flutter 1.10.7-pre.108 • channel master • http://github.com/flutter/flutter
Framework • revision e045ef2969 (27 minutes ago) • 2019-10-01 14:10:53 -0700
Engine • revision 5c428d9247
Tools • Dart 2.6.0 (build 2.6.0-dev.4.0 fb1c5a6404)

The above reproduce scenario doesn't lead to an issue.
I cannot assert that your fix works.

And
I like to point out that form the flutter master channel, bad builds occurs.
That is why we have chosen the beta channel as your compatible one (README #version-compatibility), your log info from hover should contain the following message if you diverge:

$ hover run
[....]
hover: ⚠ The go-flutter project tries to stay compatible with the beta channel of Flutter.
hover: ⚠     It's advised to use the beta channel: flutter channel beta
[....]

@JasCodes, to avoid any other bad build that are unrelated to go-flutter/hover, please make sure to switch to the beta branch 😉.
This issue was fixed by: flutter/flutter#41401, closing the go-flutter-desktop/hover#37 PR.