bugfix: message size was using int instead uint #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #163: When using StandardMessageCodec, the Flutter Framework encode the value's size using it's own format: https://api.flutter.dev/flutter/services/StandardMessageCodec/readSize.html When the size value is above 254, the format used is **unsigned** int 16 or 32.
pchampio
force-pushed
the
fix/msgSizeEncoding
branch
from
2ac9c3a to
0fa4be9
Compare
|
The solution seems clear, but we should create |
GeertJohan
requested changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #163: When using StandardMessageCodec, the Flutter Framework encode
the value's size using it's own format:
https://api.flutter.dev/flutter/services/StandardMessageCodec/readSize.html
When the size value is above 254, the format used is unsigned int 16 or
32.