Make the scroll amount configurable #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm if the scroll amount is wrong compared to the official flutter implementations why don't change it to the official scroll amount? But that could still be achieved with your PR. |
|
Well, I made it that way in case you care about breaking changes in the behavior of the existing apps. |
|
I don't think anyone ever tried fixing the scroll in their app. So I guess it would fix it for everyone. @pchampio |
pchampio
reviewed
Mar 31, 2020
pchampio
approved these changes
Mar 31, 2020
|
@pchampio Ok, great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #379
The scroll amount remains unchanged. The PR makes the amount configurable with the config struct.