Skip to content

Conversation

@james-lawrence
Copy link
Contributor

final piece for supporting go.mod located in parent directory. final change for go-flutter-desktop/go-flutter#357

@GeertJohan GeertJohan requested review from GeertJohan and pchampio July 7, 2020 12:06
@GeertJohan
Copy link
Member

Sorry for the late response @james-lawrence , this PR is on my TODO now.

Copy link
Member

@pchampio pchampio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter create --template=plugin test_hover
cd test_hover
hover init-plugin github.com/my-organization/test_hover
cd example
flutter build bundle
hover init
mv go/go.mod . # Is this what we want to fix?
mv go/go.sum .
hover plugins get
yes | hover run

Works!
LGTM (given I have understand what this fixes)

@GeertJohan GeertJohan merged commit 46fcc68 into go-flutter-desktop:master Jul 7, 2020
@james-lawrence
Copy link
Contributor Author

yessir. =)

@james-lawrence james-lawrence deleted the gomod-improvements-module-root branch September 26, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants