Skip to content

Improve missing packaging tools instructions #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 1 commit into from
Oct 29, 2020
Merged

Improve missing packaging tools instructions #168

provokateurin merged 1 commit into from
Oct 29, 2020

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Oct 16, 2020

Closes go-flutter-desktop/go-flutter#523
The new output of hover doctor:

hover: Hover version (devel) running on linux
hover: Sharing packaging tools
hover: darwin-bundle is supported
hover: darwin-dmg is supported
hover: darwin-pkg is supported
hover: To package linux-appimage these tools are required: appimagetool
hover: Install appimagetool from your package manager or from https://github.com/AppImage/AppImageKit#appimagetool-usage
hover: To still package linux-appimage without the required tools installed you need to run hover with the `--docker` flag.
hover: linux-deb is supported
hover: linux-pkg is supported
hover: linux-rpm is supported
hover: To package linux-snap these tools are required: snapcraft
hover: Install snapd from your package manager or from https://snapcraft.io/docs/installing-snapd
hover: To still package linux-snap without the required tools installed you need to run hover with the `--docker` flag.
hover: To package windows-msi these tools are required: wixl
hover: Install msitools from your package manager or from https://wiki.gnome.org/msitools/
hover: To still package windows-msi without the required tools installed you need to run hover with the `--docker` flag.
hover: 
hover: Sharing flutter version
...

The new output of hover build [unsupported]:

hover: Downloading engine for platform windows-debug_unopt at version 1bc025d6cbf1136c2e96c6fb041d24202ea47ff0...
Download completed in 28.32s
hover: To package windows-msi these tools are required: wixl
hover: Install msitools from your package manager or from https://wiki.gnome.org/msitools/
hover: To still package windows-msi without the required tools installed you need to run hover with the `--docker` flag.

The output is a bit messy, but clear enough to find issues.

@MathiasDeWeerdt
Copy link

MathiasDeWeerdt commented Oct 21, 2020 •
edited
Loading

$ hover build darwin-pkg

hover: Using engine from cache
hover: To package darwin-bundle these tools are required: png2icons
hover: To still package darwin-bundle without the required tools installed you need to run hover with the --docker flag.

Any idea what package I need to install on OSX to resolve this issue?

edit: nvm found it, https://github.com/idesis-gmbh/png2icons/releases

@provokateurin
Copy link
Member Author

provokateurin commented Oct 21, 2020

The instructions for png2icons is missing, because it's not used after #167

GeertJohan
GeertJohan reviewed Oct 25, 2020
View reviewed changes
cmd/packaging/darwin-dmg.go
cmdCreateBundle = exec.Command("hdiutil", "create", "-volname", packageName, "-srcfolder", "dmgdir", "-ov", "-format", "UDBZ", outputFileName)
case "linux":
cmdGenisoimage = exec.Command("genisoimage", "-V", packageName, "-D", "-R", "-apple", "-no-pad", "-o", outputFileName, "dmgdir")
cmdCreateBundle = exec.Command("mkisofs", "-V", packageName, "-D", "-R", "-apple", "-no-pad", "-o", outputFileName, "dmgdir")
Copy link
Member

@GeertJohan GeertJohan Oct 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not in the PR description 😁
Why move to mkisofs? (I don't know anything about genisoimage vs mkisofs, just curious here)

Copy link
Member Author

@provokateurin provokateurin Oct 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

genisoimage is a fork of mkisofs which is really only used in Ubuntu. To make it compatible for more people I changed it. I also now noticed that I forgot to change to docker image to make it working. But you are right it probably shouldn't be changed in this PR.

Copy link
Member Author

@provokateurin provokateurin Oct 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the symlink to the Dockerfile. I would still change from genisoimage to mkisofs in this PR if that is ok for you

Copy link
Member

@GeertJohan GeertJohan Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of asking users to create a symlink, we could first look for the alternative (genisoimage) and use that if it is available. But that's something for a different PR

GeertJohan
GeertJohan reviewed Oct 25, 2020
View reviewed changes
@provokateurin provokateurin force-pushed the improved-packaging-tools-instructions branch from debae44 to f1da3e8 Compare October 26, 2020 14:14
@provokateurin provokateurin force-pushed the improved-packaging-tools-instructions branch from f1da3e8 to b71e3ae Compare October 26, 2020 14:16
@provokateurin provokateurin merged commit fb103e4 into master Oct 29, 2020
@provokateurin provokateurin deleted the improved-packaging-tools-instructions branch October 29, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeertJohan GeertJohan GeertJohan left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@provokateurin @MathiasDeWeerdt @GeertJohan